Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies: fixes linter #601

Merged

Conversation

gselderslaghs
Copy link
Member

Proposed changes

Fix for linter error on current dev version

Current behavior

Current ESLint version results in
TypeError: Error while loading rule '@typescript-eslint/no-unused-expressions': Cannot read properties of undefined (reading 'allowShortCircuit')
Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.

Solution

  • Using the latest dependencies fixes this issue, particularly this issue was a bug in @typescript-eslint/eslint-plugin and fixes the TypeError
  • Renamed compress.js to compress.mjs to fix the warning
  • Additionally resolved linter warning "unexpected aliasing of 'this'" on Utils component

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io wuda-io self-requested a review February 23, 2025 12:16
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha ok thats good 👍

@wuda-io wuda-io merged commit 9bf221d into materializecss:v2-dev Feb 23, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants