Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/replace regex #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nastymorbol
Copy link

Replaced some Regex with constant expressions for performance improvement.

@s-michael-telford
Copy link

I considered making similar changes, but was going to recommend using the built it char static functions instead. Specifically, char.IsAsciiDigit or char.IsDigit, char.IsAsciiLetter or char.IsLetter etc.

@nastymorbol
Copy link
Author

Since the static char functions are unicode, i prefer to work with explicit ASCII characters. Unfortunately, I already had problems where my customers used some unicode characters using copy paste, which I then misinterpreted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants