Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

105 added registry and tests #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ved1beta
Copy link
Collaborator

No description provided.

Copy link
Owner

@mathysgrapotte mathysgrapotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • you are merging to main instead of dev (you have to fork from dev and merge to dev 🙂 )

  • can you write a bit of doc on how to use the registry system? I can see you have a decorator system which is awesome, it would be nice to have a test that implements how this is supposed to be used in practice (so you can try to register a new encoder for instance and see if it's in the registry system).

  • you have quality-checks failing (mkdocs), you want to be running make check, make check-quality, make test and make docs locally to make sure everything is fine (any warning from make docs will need to be fixed).

Other than that; the code looks great already, easy to understand, well documented, Bravo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants