Visual snapshots improvements (part 2) (#91)

* Remove old B2 upload * Run even if not PR
matiaskorhonen · Sep 27, 2023 · a35dd6b · a35dd6b
1 parent 2f00d84
commit a35dd6b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 22 deletions.
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -196,24 +196,3 @@ jobs:
       with:
         name: visual-snapshots
         path: visual-snapshots
-    - name: Upload to B2
-      uses: shallwefootball/s3-upload-action@master
-      id: B2
-      with:
-        aws_key_id: ${{ secrets.AWS_KEY_ID }}
-        aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY}}
-        aws_bucket: ${{ vars.AWS_BUCKET }}
-        endpoint: ${{ vars.AWS_ENDPOINT }}
-        source_dir: "visual-snapshots"
-        destination_dir: "30-days/${{ github.repository }}/${{ github.run_id }}"
-    - name: Generate snapshots comment
-      run: ./bin/snapshots-comment '${{steps.B2.outputs.object_locations}}'
-    - uses: jwalton/gh-find-current-pr@v1
-      id: finder
-    - uses: marocchino/sticky-pull-request-comment@v2
-      with:
-        number: ${{ steps.finder.outputs.pr }}
-        header: "Visual Snapshots"
-        path: "./visual-snapshots.tmp"
-    - name: Job summary (visuals)
-      run: cat visual-snapshots.tmp > $GITHUB_STEP_SUMMARY
diff --git a/.github/workflows/upload.yml b/.github/workflows/upload.yml
@@ -16,7 +16,6 @@ jobs:
     runs-on: ubuntu-latest
 
     if: >
-      github.event.workflow_run.event == 'pull_request' &&
       github.event.workflow_run.conclusion == 'success'
 
     env:
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,6 @@ jobs: @@
         runs-on: ubuntu-latest
         if: >
-          github.event.workflow_run.event == 'pull_request' &&
           github.event.workflow_run.conclusion == 'success'
         env:
@@ Expand Down @@