resolved problems

package.json

@@ -56,7 +56,6 @@
     "html-creator": "^0.7.2",
     "nodegit": "^0.28.0-alpha.26",
     "ts-morph": "^22.0.0",
-    "@stoplight/better-ajv-errors": "^1.0.3",
     "node-fetch": "^2.7.0",
     "ajv": "^4.11.8",
     "better-ajv-errors": "^0.6.7"

src/Report/ADFValidator.ts

@@ -1,16 +1,16 @@
 const nodeFetch = require("node-fetch");
-const betterAjvErrors = require('better-ajv-errors');
-import Ajv from 'ajv';
-import { Logger } from '../Logger/Logger';
+const betterAjvErrors = require("better-ajv-errors");
+import Ajv from "ajv";
+import { Logger } from "../Logger/Logger";
 
 export class ADFValidator {
     private static SCHEMA_URL = "https://unpkg.com/@atlaskit/[email protected]/dist/json-schema/v1/full.json";
 
-    private _schema: Object;
+    private _schema: unknown;
 
     public constructor() { }
 
-    public async loadSchema(): Promise<any> {
+    public async loadSchema(): Promise<void> {
         console.log("[ADFValidator] Fetching latest JSON schema");
 
         const response = await nodeFetch(ADFValidator.SCHEMA_URL);
@@ -29,7 +29,7 @@ export class ADFValidator {
         console.log("[ADFValidator] Validating ADF...");
 
         if (!this._schema) {
-            throw new Error(`[ADFValidator] Schema is not loaded yet, call await loadSchema() before validation`);
+            throw new Error("[ADFValidator] Schema is not loaded yet, call await loadSchema() before validation");
         }
 
         const ajv = new Ajv({ jsonPointers: true });

src/scope.ts

@@ -1,4 +1,4 @@
-#!/usr/bin/env nodeimport { runUntagCommand } from "./Commands/runUntagCommand";
+#!/usr/bin/env node
 import { runCommitCommand } from "./Commands/runCommitCommand";
 import { runAddCommand } from "./Commands/runAddCommand";
 import { runVerifyCommand } from "./Commands/runVerifyCommand";
@@ -91,5 +91,5 @@ switch (args[0]) {
 }
 
 export function getScriptVersion(): string {
-    return require('../package.json').version;
+    return require("../package.json").version;
 }

test/report/reportGenerator.test.ts

@@ -25,10 +25,9 @@ const initReportGenerator = (root: string) => {
     tags.load();
 
     return new ReportGenerator(repository, tags, database, config, [tsReferenceFinder], PRINT_DEBUG_INFO);
-}
+};
 
-
-describe("Report generation works as expected", async () => {
+describe("Report generation works as expected", () => {
     it("After making a change in a tagged file, the change is correctly described by generated report", async () => {
         const FOLDER_PATH = makeUniqueFolderForTest();
         const REPO_PATH = cloneMockRepositoryToFolder(FOLDER_PATH);

test/scope/qualityTests.test.ts

@@ -0,0 +1,10 @@
+import { getFirstLine } from "../utils/utils";
+
+describe("Quality checks", () => {
+  it("Check if the first line of scope.ts is correct (sometimes there is 'nodeimport' there)", async () => {
+    const EXPECTED_FIRST_LINE = "#!/usr/bin/env node";
+
+    const firstLine = await getFirstLine("./src/scope.ts");
+    expect(firstLine).toBe(EXPECTED_FIRST_LINE);
+  });
+});

test/utils/utils.ts

@@ -4,8 +4,10 @@ import { MOCK_REMOTE_URL, MOCK_REPOSITORY, TEST_DATA_FOLDER } from "./globals";
 
 import * as uuid from "uuid";
 import { GitRepository } from "../../src/Git/GitRepository";
-import rimraf from "rimraf";
 import { execSync } from "child_process";
+import * as rimraf from "rimraf";
+import fs from "fs";
+import readline from "readline";
 
 // Mocked repository
 
@@ -162,4 +164,18 @@ export const commitFilesUsingGitNatively = (
     commitMessage = "test commit"
 ) => {
     execSync(`cd ${repositoryPath} && git add ${fileNames.join(" ")} && git commit -m "${commitMessage}"`);
-};
+};
+
+// https://stackoverflow.com/questions/28747719/what-is-the-most-efficient-way-to-read-only-the-first-line-of-a-file-in-node-js
+export async function getFirstLine(pathToFile: string): Promise<string> {
+    const readable = fs.createReadStream(pathToFile);
+    const reader = readline.createInterface({ input: readable });
+    const line: string = await new Promise((resolve) => {
+        reader.on("line", (line) => {
+            reader.close();
+            resolve(line);
+        });
+    });
+    readable.close();
+    return line;
+}