Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are the warnings associated with my changes
+ /usr/local/bin/ocamlfind ocamlopt -c -g -annot -bin-annot -I src/typing -I src -I src/utils -I src/runtime -I src/parsing -o src/typing/exhaust.cmx src/typing/exhaust.ml File "src/typing/exhaust.ml", line 93, characters 22-231: Warning 8: this pattern-matching is not exhaustive. Here is an example of a case that is not matched: (In_channel _|Out_channel _) File "src/typing/exhaust.ml", line 99, characters 21-261: Warning 8: this pattern-matching is not exhaustive. Here is an example of a case that is not matched: (In_channel _|Out_channel _)
I am sorry I did not get to fix them
I added an example of using files in the examples directory
I also would not forget to mention that this work is adapted from what zigaLuksic helped me with. The read_file effect is written by him
Thanks,
Ghadeer