fix: incorrect annotation methods for github core

matmar10 · Apr 4, 2022 · f363de3 · f363de3
1 parent fbaec4b
commit f363de3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -1444,7 +1444,6 @@ async function run() {
       if (reviewAppUpdatedAt > prUpdatedAt) {
         core.info('Review app updated after PR; OK.');
         core.endGroup();
-        core.success('Action complete');
         return;
       }
       core.info('Review app updated before PR; need to wait for review app.');
@@ -1538,7 +1537,7 @@ async function run() {
           throw err;
         }
         // possibly build kicked off after this PR action began running
-        core.warn('Review app now seems to exist...');
+        core.warning('Review app now seems to exist after previously not...');
         core.endGroup();
 
         // just some sanity checking
@@ -1566,8 +1565,7 @@ async function run() {
     })}`);
 
     if (forkRepo) {
-      core.warn('No secrets are available for PRs in forked repos.');
-      core.success('Action complete');
+      core.notice('No secrets are available for PRs in forked repos.');
       return;
     }
 
@@ -1601,7 +1599,6 @@ async function run() {
         await heroku.delete(`/review-apps/${app.id}`);
         core.info('PR closed, deleted review app OK');
         core.endGroup();
-        core.success('Action complete');
       } else {
         core.error(`Could not find review app for PR #${prNumber}`);
         core.endGroup();
@@ -1637,7 +1634,6 @@ async function run() {
       core.debug('No label specified; will not label PR');
     }
 
-    core.success('Action complete');
   } catch (err) {
     core.error(err);
     core.setFailed(err.message);

diff --git a/index.js b/index.js
@@ -68,7 +68,6 @@ async function run() {
       if (reviewAppUpdatedAt > prUpdatedAt) {
         core.info('Review app updated after PR; OK.');
         core.endGroup();
-        core.success('Action complete');
         return;
       }
       core.info('Review app updated before PR; need to wait for review app.');
@@ -162,7 +161,7 @@ async function run() {
           throw err;
         }
         // possibly build kicked off after this PR action began running
-        core.warn('Review app now seems to exist...');
+        core.warning('Review app now seems to exist after previously not...');
         core.endGroup();
 
         // just some sanity checking
@@ -190,8 +189,7 @@ async function run() {
     })}`);
 
     if (forkRepo) {
-      core.warn('No secrets are available for PRs in forked repos.');
-      core.success('Action complete');
+      core.notice('No secrets are available for PRs in forked repos.');
       return;
     }
 
@@ -225,7 +223,6 @@ async function run() {
         await heroku.delete(`/review-apps/${app.id}`);
         core.info('PR closed, deleted review app OK');
         core.endGroup();
-        core.success('Action complete');
       } else {
         core.error(`Could not find review app for PR #${prNumber}`);
         core.endGroup();
@@ -261,7 +258,6 @@ async function run() {
       core.debug('No label specified; will not label PR');
     }
 
-    core.success('Action complete');
   } catch (err) {
     core.error(err);
     core.setFailed(err.message);