Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LookupWellKnown to read full response #441

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Oct 29, 2024

Fix a bug in LookupWellKnown which would cause it only to read part of the HTTP response body if it spanned multiple TCP segments.

Fixes: #440

Fix a bug in `LookupWellKnown` which would cause it only to read part of the
HTTP response body if it spanned multiple TCP segments.

Fixes: #440
Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hu, interesting. Wondering why that didn't bite us earlier.

@richvdh richvdh merged commit dbd5f31 into main Nov 6, 2024
4 checks passed
@richvdh richvdh deleted the rav/fix_lookup_well_known branch November 6, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LookupWellKnown fails to parse well-known if response spans multiple tcp segments
2 participants