Performance and bug-fix backports #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains various backports: * Reduced allocations and performance improvements in state resolution * Reduced allocations and performance improvements in JSON handling * Event auth fixes, including correct error surfacing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
==========================================
- Coverage 59.85% 59.68% -0.18%
==========================================
Files 51 51
Lines 7146 7158 +12
==========================================
- Hits 4277 4272 -5
- Misses 2477 2489 +12
- Partials 392 397 +5 ☔ View full report in Codecov by Sentry. |
neilalexander
force-pushed
the
neil/backports
branch
from
1936291 to
3d48766
Compare
S7evinK
approved these changes
Dec 15, 2024
authstate.go
Outdated
Comment on lines
168
to
171
| authEvents, err := NewAuthEvents(nil) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Given this always returns a nil error, may be worth to remove the err check? (Similar for other call sites where we pass in nil)
| @@ -31,4 +31,4 @@ require ( | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
| go 1.18 | |||
| go 1.22 | |||
stateresolutionv2.go
Outdated
| addFromAuthEventsIfNotRejected := func(event PDU, eventType, stateKey string) { | ||
| for _, authEventID := range event.AuthEventIDs() { | ||
| if _, ok := r.isRejectedCache[authEventID]; !ok { | ||
| r.isRejectedCache[authEventID] = r.isRejectedFn(authEventID) |
There was a problem hiding this comment.
To avoid having to lookup the authEventID right after setting it
Suggested change
| r.isRejectedCache[authEventID] = r.isRejectedFn(authEventID) | |
| isRejected := r.isRejectedFn(authEventID) | |
| r.isRejectedCache[authEventID] = isRejected | |
| if isRejected { | |
| continue | |
| } |
neilalexander
force-pushed
the
neil/backports
branch
from
e090245 to
0d17b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains various backports from Harmony:
PerformBackfillcallsCloses #439 as superseded by changes in this PR.
Signed-off-by: Neil Alexander [email protected]