This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Add more information to session detail page #1659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
Latest commit: |
8d44bdc
|
Status: | ✅ Deploy successful! |
Preview URL: | https://950132e3.matrix-authentication-service-docs.pages.dev |
Branch Preview URL: | https://kerry-1550-session-detail-mo.matrix-authentication-service-docs.pages.dev |
sandhose
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The displayed fields look like a good start to me. So given that we have only one day left before the deadline, I wouldn't block this pull request on it. If needed, we can follow up afterwards. If the logo would be trivial to include, agree that it would be a pretty fancy addition. 🙂 |
Made a ticket for logo, will work on it after the redirect if I have time #1672 |
Looks good for now, thanks. Some fields are certainly a bit technical and need design review but we can do that in a later release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1550
Compatibility session:


Oauth2 session:
In next PRs: