Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit aggregate room beacon liveness #2241

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Mar 15, 2022

matrix-org/matrix-spec-proposals#3489

Done:

  • Send m.beacon_info.* state events.
  • track m.beacon_info.* events in room state

In this PR:

  • expose and maintain 'user room has live beacons' property in room state
  • add ability to monitor liveness of beacon

In next PRs:

  • get users own beacons from room state, monitor liveness and show live state
  • produce good unique suffixes for beacon info events
  • geolocate and send m.beacon events for live beacons
  • maintain liveness state of beacons (checking for expiry, flipping isLive on event content)
  • maintain 'user has live beacons' property

Here's what your changelog entry will look like:

✨ Features

Kerry Archibald added 2 commits March 15, 2022 14:43
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
@kerryarchibald kerryarchibald requested a review from a team as a code owner March 15, 2022 13:51
Kerry Archibald added 2 commits March 15, 2022 15:06
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #2241 (2352abc) into develop (c2fdb44) will increase coverage by 0.08%.
The diff coverage is 97.36%.

@@             Coverage Diff             @@
##           develop    #2241      +/-   ##
===========================================
+ Coverage    57.96%   58.05%   +0.08%     
===========================================
  Files           92       92              
  Lines        16345    16381      +36     
  Branches      3764     3772       +8     
===========================================
+ Hits          9475     9510      +35     
- Misses        6870     6871       +1     
Impacted Files Coverage Δ
src/matrix.ts 63.15% <ø> (ø)
src/models/beacon.ts 97.56% <96.00%> (-2.44%) ⬇️
src/models/room-state.ts 75.47% <100.00%> (+1.05%) ⬆️
src/models/event.ts 66.34% <0.00%> (ø)
src/models/thread.ts 56.03% <0.00%> (+0.77%) ⬆️

@@ -0,0 +1,12 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing copyright

Signed-off-by: Kerry Archibald <[email protected]>
@kerryarchibald kerryarchibald enabled auto-merge (squash) March 16, 2022 08:49
@kerryarchibald kerryarchibald merged commit 18943d6 into develop Mar 16, 2022
@kerryarchibald kerryarchibald deleted the psf-662/live-beacon-status branch March 16, 2022 08:54
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Apr 1, 2022
* emit aggregate room beacon liveness ([\matrix-org#2241](matrix-org#2241)).
* Live location sharing - create m.beacon_info events ([\matrix-org#2238](matrix-org#2238)).
* Beacon event types from MSC3489 ([\matrix-org#2230](matrix-org#2230)).
* Fix incorrect usage of unstable variant of `is_falling_back` ([\matrix-org#2227](matrix-org#2227)).
wx870601 added a commit to eachchat/matrix-js-sdk that referenced this pull request Apr 6, 2022
* emit aggregate room beacon liveness ([\matrix-org#2241](matrix-org#2241)).
* Live location sharing - create m.beacon_info events ([\matrix-org#2238](matrix-org#2238)).
* Beacon event types from MSC3489 ([\matrix-org#2230](matrix-org#2230)).
* Fix incorrect usage of unstable variant of `is_falling_back` ([\matrix-org#2227](matrix-org#2227)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants