PR review suggestions for https://github.com/matrix-org/matrix-js-sdk/pull/4583 #4588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
force-pushed
the
hughns/refactor-matrixrtc-extra
branch
2 times, most recently
from
5eee64a to
d0d8c93
Compare
hughns
force-pushed
the
hughns/refactor-matrixrtc-extra
branch
from
d0d8c93 to
e31adb9
Compare
Whilst a good idea it makes it clearer what is and isn't being changed in the PR.
So this is the same as before. Also the value looked wrong (it was set to 40 minutes not 4 hours)
hughns
force-pushed
the
hughns/refactor-matrixrtc-extra
branch
from
e31adb9 to
4dccced
Compare
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for #4583
See individual commits which should be self-contained and cherry-pickable.
Checklist
public/exportedsymbols have accurate TSDoc documentation.