Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure room is in store before emitting events from it #4617

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Ensure room is in store before emitting events from it #4617

wants to merge 3 commits into from

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 15, 2025 •
edited
Loading

Otherwise things reacting to timeline/state events on the client may call getRoom get null and panic.

@t3chguy
Iterate
6c91b8d 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
006a80b 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review January 15, 2025 11:51
@t3chguy t3chguy requested a review from a team as a code owner January 15, 2025 11:51
@t3chguy t3chguy requested review from dbkr and MidhunSureshR January 15, 2025 11:51
@t3chguy t3chguy self-assigned this Jan 15, 2025
dbkr
dbkr approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly suspicious that we didn't do this before, but it seems sensible.

@t3chguy t3chguy added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@t3chguy
Copy link
Member Author

t3chguy commented Jan 15, 2025

Looks like this may need a different solution, this seems to break some edge cases

@t3chguy t3chguy marked this pull request as draft January 15, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @dbkr