-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SyncCryptoCallback
api instead of legacy crypto in sliding sync
#4624
Merged
florianduros
merged 1 commit into
develop
from
florianduros/rip-out-legacy-crypto/sliding-sync
Jan 17, 2025
Merged
Use SyncCryptoCallback
api instead of legacy crypto in sliding sync
#4624
florianduros
merged 1 commit into
develop
from
florianduros/rip-out-legacy-crypto/sliding-sync
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/sliding-sync
branch
from
January 17, 2025 08:32
9551773
to
1dfeaac
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/sliding-sync
branch
from
January 17, 2025 08:47
1dfeaac
to
493ca94
Compare
florianduros
changed the title
Use SyncCryptoCallback api instead of legacy crypto in sliding sync
Use Jan 17, 2025
SyncCryptoCallback
api instead of legacy crypto in sliding sync
florianduros
commented
Jan 17, 2025
Comment on lines
-643
to
-648
afterAll(async () => { | ||
// needed else we do some async operations in the background which can cause Jest to whine: | ||
// "Cannot log after tests are done. Did you forget to wait for something async in your test?" | ||
// Attempted to log "Saving device tracking data null"." | ||
client!.crypto!.stop(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work without it and doesn't add more error message.
dbkr
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks plausible!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 17, 2025
florianduros
deleted the
florianduros/rip-out-legacy-crypto/sliding-sync
branch
January 17, 2025 11:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public
/exported
symbols have accurate TSDoc documentation.Replace the usage of deprecated
MatrixClient.crypto
by theSyncCryptoCallback
api.Hopefully, they can be swapped without any difficulty because
ExtensionE2EE
is using shared methods between legacy crypto andSyncCryptoCallback
:matrix-js-sdk/src/sliding-sync-sdk.ts
Lines 67 to 101 in 1dfeaac
The
syncCryptoCallback
parameter is already provided in the matrixClient:matrix-js-sdk/src/client.ts
Lines 1552 to 1566 in 1dfeaac