Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch OIDC primarily to new /auth_metadata API #4626

Merged
merged 8 commits into from
Jan 22, 2025
Merged

Switch OIDC primarily to new /auth_metadata API #4626

merged 8 commits into from
Jan 22, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 17, 2025 •
edited
Loading

Updates to latest variant of https://github.com/sandhose/matrix-spec-proposals/blob/msc/sandhose/oidc-discovery/proposals/2965-auth-metadata.md

Also drastically simplifies the overly-duplicated config/metadata interfaces

@t3chguy t3chguy mentioned this pull request Jan 17, 2025
Merged
@t3chguy
Add missing issuer prop in tests
d77f2ea 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Update tests
9f7e7ee 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
delint
6111f7c 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
1fe7e9b 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Simplify the world
708ab84 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
3e19d45 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review January 20, 2025 12:59
@t3chguy t3chguy requested a review from a team as a code owner January 20, 2025 12:59
@t3chguy t3chguy requested review from dbkr and florianduros January 20, 2025 12:59
@t3chguy t3chguy self-assigned this Jan 20, 2025
dbkr
dbkr approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

src/oidc/discovery.ts Outdated Show resolved Hide resolved
@t3chguy
Add comment
bc0962b 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@t3chguy t3chguy merged commit c0e30ce into develop Jan 22, 2025
30 checks passed
@t3chguy t3chguy deleted the t3chguy/oidc-auth-metdata branch January 22, 2025 13:48
@sandhose sandhose mentioned this pull request Jan 22, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @dbkr