Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CryptoApi.resetEncryption should always create a new key backup #4648

Merged
merged 3 commits into from
Jan 23, 2025
Merged

CryptoApi.resetEncryption should always create a new key backup #4648

merged 3 commits into from
Jan 23, 2025

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jan 23, 2025 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Following discussion in #4614 (comment).

  • We decided to always create a new key backup at the end of resetEncryption.
  • Add logging to help futur RS.

@florianduros florianduros force-pushed the florianduros/reset-encrytion-fix branch from 9ac5ecb to bc48007 Compare January 23, 2025 09:42
@florianduros florianduros force-pushed the florianduros/reset-encrytion-fix branch from bc48007 to e69f10f Compare January 23, 2025 09:42
@florianduros florianduros marked this pull request as ready for review January 23, 2025 09:50
@florianduros florianduros requested a review from a team as a code owner January 23, 2025 09:50
@florianduros florianduros added this pull request to the merge queue Jan 23, 2025
Merged via the queue into develop with commit ed397d9 Jan 23, 2025
38 checks passed
@florianduros florianduros deleted the florianduros/reset-encrytion-fix branch January 23, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

@richvdh richvdh Awaiting requested review from richvdh richvdh is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @BillCarsonFr