Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Fix missing aria identifiers for the Extensions tab
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Telatynski <[email protected]>
  • Loading branch information
t3chguy committed Aug 6, 2024
1 parent ca8d63a commit 69ac1cc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
9 changes: 8 additions & 1 deletion src/components/views/right_panel/ExtensionsCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,14 @@ const ExtensionsCard: React.FC<Props> = ({ room, onClose }) => {
}

return (
<BaseCard header={header} className="mx_ExtensionsCard" onClose={onClose} hideHeaderButtons>
<BaseCard
header={header}
className="mx_ExtensionsCard"
onClose={onClose}
hideHeaderButtons
id="extensions-panel"
ariaLabelledBy="extensions-panel-tab"
>
{body}
</BaseCard>
);
Expand Down
2 changes: 1 addition & 1 deletion src/components/views/right_panel/RightPanelTabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const RightPanelTabs: React.FC<Props> = ({ phase, room }): JSX.Element |
!isVideoRoom &&
shouldShowComponent(UIComponent.AddIntegrations) && (
<NavItem
aria-controls="thread-panel"
aria-controls="extensions-panel"
id="extensions-panel-tab"
onClick={() => {
RightPanelStore.instance.pushCard({ phase: RightPanelPhases.Extensions }, true);
Expand Down

0 comments on commit 69ac1cc

Please sign in to comment.