Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Deprecate lab experiment 'feature_state_counters' #11343

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Jul 31, 2023

For element-hq/element-web#25883
Fixes element-hq/element-web#25884
To review alongside element-hq/element-web#25885

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 31, 2023
@germain-gg
Copy link
Contributor Author

Closing as we will have this removed as part of removing the legacy room header

@germain-gg germain-gg closed this Aug 22, 2023
@Johennes Johennes reopened this Nov 22, 2023
@Johennes
Copy link
Contributor

Reopening this because this feature appears to be available with both the old and new header. So removing it doesn't have to block on removing the old header code.

@Johennes Johennes marked this pull request as ready for review November 22, 2023 15:17
@Johennes Johennes requested a review from a team as a code owner November 22, 2023 15:17
@robintown robintown removed the request for review from kerryarchibald November 29, 2023 23:19
@Johennes Johennes added this pull request to the merge queue Nov 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@Johennes Johennes added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@Johennes Johennes deleted the germain-gg/25884 branch November 30, 2023 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate feature_state_counters
3 participants