This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Extract place call logic to its own file #11494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
added
the
T-Task
weeman1337
reviewed
Aug 31, 2023
| @@ -150,7 +126,7 @@ export default function RoomHeader({ room }: { room: Room }): JSX.Element { | |||
| disabled={!!voiceCallDisabledReason} | |||
| title={!voiceCallDisabledReason ? _t("Voice call") : voiceCallDisabledReason!} | |||
| onClick={async () => { | |||
There was a problem hiding this comment.
Just spotted the async here. The function is not async and it could be removed.
| // component | ||
| // break; | ||
| } | ||
| const makeCall = useCallback( |
There was a problem hiding this comment.
This function can probably be removed and placeCall can be called directly.
I can't see any value in it except that it raises the complexity here.
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.