Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

More tests for reactions to messages in threads #11612

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Sep 18, 2023

Part of element-hq/element-web#25449
Builds on #11594 but overlap is trivial.


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 18, 2023
@andybalaam andybalaam marked this pull request as ready for review September 18, 2023 10:47
@andybalaam andybalaam requested a review from a team as a code owner September 18, 2023 10:47
@andybalaam andybalaam requested review from t3chguy and weeman1337 and removed request for a team September 18, 2023 10:47
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪿

@andybalaam
Copy link
Member Author

Test failure looks like an infrastructure flake of some kind:

Timed out retrying after 10000ms: Expected to find element: .mx_ThreadPanel, but never found it.
[cypress/e2e/read-receipts/high-level.spec.tsat line396](https://github.com/matrix-org/matrix-react-sdk/blob/e0915768966b6db695a94de996105afc0a9451f2/cypress/e2e/read-receipts/high-level.spec.ts#L396)

@andybalaam
Copy link
Member Author

(Or at least it passes for me locally)

Base automatically changed from andybalaam/more-tests-for-redactions to develop September 18, 2023 15:41
@andybalaam andybalaam added this pull request to the merge queue Sep 19, 2023
Merged via the queue into develop with commit d46d4b3 Sep 19, 2023
19 checks passed
@andybalaam andybalaam deleted the andybalaam/reaction-tests branch September 19, 2023 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants