This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
added setting not to show indirect rooms of spaces in left sidebar #12317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Setting "Space.showIndirectRoomsInSpace" (matrix-org#418) * Changed SpaceFilterCondition and its tests to comply with new setting * Changed SpaceStore to watch new setting and if updated emit event SpaceFilterCondition already listens for. Added a test for it. Signed-off-by: Julius Schuchert <[email protected]>
github-actions
bot
added
the
Z-Community-PR
|
Related #7682 |
t3chguy
reviewed
Mar 6, 2024
| private space: SpaceKey = MetaSpace.Home; | ||
|
|
||
| public isVisible(room: Room): boolean { | ||
| return SpaceStore.instance.isRoomInSpace(this.space, room.roomId); | ||
| return SpaceStore.instance.isRoomInSpace(this.space, room.roomId, this.showIndirectRoomsInSpace); | ||
| } | ||
|
|
||
| private onStoreUpdate = async (forceUpdate = false): Promise<void> => { |
There was a problem hiding this comment.
Looks like this.roomIds and this.userIds don't respect this.showIndirectRoomsInSpace
|
there's not enough detail here for me to be able to follow the product changes. Are there screenshots of what the user experience was and will be with this change? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julius Schuchert [email protected]