This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Tooltip: migrate remaining tooltips from AccessibleTooltipButton to AccessibleButton
#12522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/accessibility/roving/RovingAccessibleTooltipButton.tsx
# Conflicts: # test/components/views/spaces/__snapshots__/SpacePanel-test.tsx.snap
…uros/tooltip/misc
…ianduros/tooltip/misc
florianduros
added
the
T-Task
|
The merge of develop decreased the code coverage check in my PR. I updated the tests to reach it. |
richvdh
changed the title
richvdh
changed the title
AccessibleTooltipButton to AccessibleButton
richvdh
approved these changes
May 17, 2024
test/components/views/auth/InteractiveAuthEntryComponent-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/auth/InteractiveAuthEntryComponent-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/auth/InteractiveAuthEntryComponent-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/auth/InteractiveAuthEntryComponent-test.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Part of element-hq/element-web#26762
Migrate the last usage of
AccessibleTooltipButtonand delete it.