Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tooltip: Use tooltip compound instead of react-sdk tooltip #12549

Merged
merged 10 commits into from
May 23, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented May 21, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Part of element-hq/element-web#26762

  • Deprecate the old tooltip.
  • Replace by the new compound tooltip.
    • The new tooltip needs to have the content to be children of the component
  • The legacy tooltip is still in used in the form field but the plan is to use an error message instead of a tooltip to display the field error. So the tooltip is not changed in this PR.
  • About the code coverage, I'm near the 80% despite to have added tests. I will ask for an exception.

@florianduros florianduros enabled auto-merge May 23, 2024 08:44
@dbkr dbkr disabled auto-merge May 23, 2024 08:52
@dbkr dbkr merged commit 88e8e2d into develop May 23, 2024
41 of 46 checks passed
@dbkr dbkr deleted the florianduros/tooltip/legacy-tooltip branch May 23, 2024 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants