Add error handling for room publish toggle

src/components/views/room_settings/RoomPublishSetting.tsx

@@ -21,6 +21,8 @@ import LabelledToggleSwitch from "../elements/LabelledToggleSwitch";
 import { _t } from "../../../languageHandler";
 import { MatrixClientPeg } from "../../../MatrixClientPeg";
 import DirectoryCustomisations from "../../../customisations/Directory";
+import Modal from "../../../Modal";
+import ErrorDialog from "../dialogs/ErrorDialog";
 
 interface IProps {
     roomId: string;
@@ -41,6 +43,13 @@ export default class RoomPublishSetting extends React.PureComponent<IProps, ISta
         };
     }
 
+    private showError(): void {
+        Modal.createDialog(ErrorDialog, {
+            title: _t("room_settings|general|error_publishing"),
+            description: _t("room_settings|general|error_publishing_detail"),
+        });
+    }
+
     private onRoomPublishChange = (): void => {
         const valueBefore = this.state.isRoomPublished;
         const newValue = !valueBefore;
@@ -49,8 +58,10 @@ export default class RoomPublishSetting extends React.PureComponent<IProps, ISta
 
         client
             .setRoomDirectoryVisibility(this.props.roomId, newValue ? Visibility.Public : Visibility.Private)
-            .catch(() => {
+            .catch((err) => {
                 // Roll back the local echo on the change
+                console.log("here")
+                this.showError();
                 this.setState({ isRoomPublished: valueBefore });
             });
     };

src/i18n/strings/en_EN.json

@@ -2221,6 +2221,8 @@
             "no_aliases_space": "This space has no local addresses",
             "other_section": "Other",
             "publish_toggle": "Publish this room to the public in %(domain)s's room directory?",
+            "error_publishing": "There was an error publishing this room",
+            "error_publishing_detail": "Not allowed to publish room",
             "published_aliases_description": "To publish an address, it needs to be set as a local address first.",
             "published_aliases_explainer_room": "Published addresses can be used by anyone on any server to join your room.",
             "published_aliases_explainer_space": "Published addresses can be used by anyone on any server to join your space.",