MSC3531 - Implementing message hiding pending moderation

[Yoric]

Notes: Implementing message hiding pending moderation (MSC3531)

This is a followup to matrix-org/matrix-js-sdk#2041 .

---

This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Preview: https://61dff9bc6685e816cdf7d5f6--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

[germain-gg]

Looks pretty good to me! Some minor things, but overall should be good to go
The CI looks unhappy

[Yoric]

Looks pretty good to me! Some minor things, but overall should be good to go The CI looks unhappy

What does it mean when the i18n tests fail with "files do not match"?

[germain-gg]

Not entirely, I have not encountered this issue before, but running yarn i18n yielded

ERROR: src/components/views/messages/TextualBody.tsx:517 Message pending moderation: %(reason)
Error: Invalid format specifier: '%(reason)'

[Yoric]

Not entirely, I have not encountered this issue before, but running yarn i18n yielded

ERROR: src/components/views/messages/TextualBody.tsx:517 Message pending moderation: %(reason)
Error: Invalid format specifier: '%(reason)'

That is really odd, it doesn't show this message on my machine. What it does is remove deprecated(?) strings and reorder them.

[Yoric]

Not entirely, I have not encountered this issue before, but running yarn i18n yielded

ERROR: src/components/views/messages/TextualBody.tsx:517 Message pending moderation: %(reason)
Error: Invalid format specifier: '%(reason)'

That is really odd, it doesn't show this message on my machine. What it does is remove deprecated(?) strings and reorder them.

Actually, it's even odder, in the patch, this string is Message pending moderation: %(reason)s (note the final "s").

[Yoric]

Apparently, I was running some deprecated scripts locally. After nuking my node_modules and a yarn install --force, it works better!

[Yoric]

I have pushed an additional patch as I realized that I wasn't handling "reply to" correctly. This should now work.

[Yoric]

Time for screenshots!

Message author

Moderator

Witness

A message is pending moderation

Attempting to respond to a message pending moderation

[germain-gg]

Looks good to me 👍

[Yoric]

Thanks for the reviews!
@gsouquet Do we need any additional UX review for this?

[germain-gg]

Re-using the message deleted styles as you did looks appropriate to me, but I've assigned @janogarcia as a reviewer for a last sanity check.
Probably good to merge and we can still adjust based on feedback at a later stage

[janogarcia]

@gsouquet @Yoric Did we reuse any design system color for the message text and icon? The blue shades in the screenshots don't look familiar to me.

[Yoric]

@gsouquet @Yoric Did we reuse any design system color for the message text and icon? The blue shades in the screenshots don't look familiar to me.

I didn't introduce anything new. I'm running both Firefox and Element Web on dark themes, I guess this may have an impact.

[turt2live]

@Yoric looks like this is missing from the labs.md on the element-web repo - can we get a small PR to add it please? 😇