Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

made signin appear on the login page and fixed the padding issue #8163

Closed
wants to merge 3 commits into from

Conversation

aryabyte21
Copy link
Contributor

@aryabyte21 aryabyte21 commented Mar 26, 2022

fixed this issue element-hq/element-web#21545

Arya Bhosale [email protected]


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • made signin appear on the login page and fixed the padding issue (#8163). Contributed by @aryabyte21.

Preview: https://pr8163--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@aryabyte21 aryabyte21 requested a review from a team as a code owner March 26, 2022 09:04
@andybalaam
Copy link
Member

andybalaam commented Mar 29, 2022

@AryaArunB the issue that you linked to is a pull request, not a bug so I'm not sure what this is fixing?

Sorry I'm talking rubbish!

@germain-gg
Copy link
Contributor

This issue was already claimed by someone else, and a PR was already open #8143
I will unfortunately have to decline this pull request

@germain-gg germain-gg closed this Mar 29, 2022
@andybalaam
Copy link
Member

@AryaArunB you can still list this work under your contributions for Outreachy. Please look for issues where there is not already a pull request attempting to fix them.

@luixxiul
Copy link
Contributor

I think this should be reopened as I've closed that PR of mine in favor of this. See: #8143 (comment)

@andybalaam
Copy link
Member

@AryaArunB are you interested in improving this to do what @janogarcia said in #8143?:

The correct way to handle it would be to use a busy state for the button (disabled button, loading spinner inside), so there are no UI reflows / layout shifts involved

@aryabyte21
Copy link
Contributor Author

Sure @andybalaam

Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this issue as draft, can you let me or Andy know when this is ready to be reviewed and we'll add this back to the queue

@germain-gg germain-gg marked this pull request as draft April 21, 2022 07:29
@MadLittleMods MadLittleMods added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Jun 1, 2022
@langleyd langleyd closed this Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants