feat: Add MediaRetentionPolicy to the EventCacheStore, take 2 #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zecakeh
force-pushed
the
media-retention-policy
branch
2 times, most recently
from
ff37e93 to
504a9d4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4571 +/- ##
==========================================
+ Coverage 85.44% 85.69% +0.24%
==========================================
Files 286 289 +3
Lines 32285 33208 +923
==========================================
+ Hits 27587 28458 +871
- Misses 4698 4750 +52 ☔ View full report in Codecov by Sentry. |
zecakeh
force-pushed
the
media-retention-policy
branch
from
6835778 to
7c4c359
Compare
Hywan
requested changes
Jan 24, 2025
crates/matrix-sdk-base/src/event_cache/store/media/media_retention_policy.rs
Show resolved
Hide resolved
crates/matrix-sdk-base/src/event_cache/store/media/media_retention_policy.rs
Outdated
Show resolved
Hide resolved
crates/matrix-sdk-base/src/event_cache/store/media/media_retention_policy.rs
Outdated
Show resolved
Hide resolved
crates/matrix-sdk-base/src/event_cache/store/media/media_retention_policy.rs
Outdated
Show resolved
Hide resolved
crates/matrix-sdk-base/src/event_cache/store/media/media_retention_policy.rs
Show resolved
Hide resolved
Hywan
reviewed
Jan 28, 2025
| @@ -12,10 +12,16 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| //! Configuration to decide whether or not to keep media in the cache, allowing | |||
| //! to do periodic cleanups to avoid to have the size of the media cache grow | |||
| //! indefinitely. | |||
There was a problem hiding this comment.
Explanation how to run a clean up, or when it is done if done automatically, would be particularly helpful!
There was a problem hiding this comment.
I added instructions for this and a sentence about automatic periodic cleanups.
Hywan
approved these changes
Jan 28, 2025
This will be used as a configuration to decide whether or not to keep media in the cache, allowing to do periodic cleanups to avoid to have the size of the media cache grow indefinitely. Signed-off-by: Kévin Commaille <[email protected]>
This is an API to handle the MediaRetentionPolicy with a lower level EventCacheStoreMedia trait. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
It is already a 3-tuple and we want to add more data so it will be clearer to use a stuct with named fields. Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
…ted changes Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
media-retention-policy
branch
from
309520b to
0334ff3
Compare
Signed-off-by: Kévin Commaille <[email protected]>
|
I merged main in this branch to solve a conflict. Maybe you would prefer a rebase? |
|
Github tells me:
Can you try resolve these conflicts please? |
|
It didn't say anything to me, but I merged main again just to be sure. I didn't encounter any conflict. |
|
The new UI was disturbing me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #3918. Since I needed to rework everything, I used a new branch.
I believe that I addressed all the comments on #3918. The API around
MediaServicewas not clear to me so I came up with something that works.It is now split into several commits that can be reviewed individually, in order.