Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3489: Sharing streams of location data with history #3489
base: main
Are you sure you want to change the base?
MSC3489: Sharing streams of location data with history #3489
Changes from 7 commits
0ed14c9
3d60c96
fde61c1
9ac2c43
de4ad14
834954a
c0a2f7b
8eb830c
cfd6208
b402c84
b98765d
09b7793
7ab68f5
99861a9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another alternative that appears not to have been discussed yet, although the idea is quite obvious:
Instead of introducing a new event
m.beacon
that for the most part duplicates an MSC3488m.location
:m.location
m.relates_to
mixin to be setPros compared to the MSC as it currently is:
m.location
m.text
Cons: