Skip to content

Commit

Permalink
Fix m.call.negotiate schema and example (#1546)
Browse files Browse the repository at this point in the history
* Fix m.call.negotiate schema and example

Signed-off-by: Kévin Commaille <[email protected]>

* Add changelog

Signed-off-by: Kévin Commaille <[email protected]>

* Add lifetime back

Signed-off-by: Kévin Commaille <[email protected]>

* Fix lifetime description

Signed-off-by: Kévin Commaille <[email protected]>

---------

Signed-off-by: Kévin Commaille <[email protected]>
  • Loading branch information
zecakeh authored Oct 3, 2023
1 parent c3098cc commit 242b62e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
1 change: 1 addition & 0 deletions changelogs/client_server/newsfragments/1546.clarification
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix `m.call.negotiate` schema and example.
2 changes: 1 addition & 1 deletion data/event-schemas/examples/m.call.negotiate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"party_id": "67890",
"call_id": "12345",
"lifetime": 10000,
"offer": {
"description": {
"type" : "offer",
"sdp" : "v=0\r\no=- 6584580628695956864 2 IN IP4 127.0.0.1[...]"
}
Expand Down
13 changes: 6 additions & 7 deletions data/event-schemas/schema/m.call.negotiate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,16 @@ properties:
allOf:
- "$ref": core-event-schema/call_event.yaml
properties:
offer:
description:
type: object
title: Offer
title: Description
description: The session description object
properties:
type:
type: string
enum:
- offer
- answer
description: The type of session description.
sdp:
type: string
Expand All @@ -60,12 +61,10 @@ properties:
- sdp
lifetime:
type: integer
description: The time in milliseconds that the invite is valid for.
Once the invite age exceeds this value, clients should discard it.
They should also no longer show the call as awaiting an answer in the
UI.
description: The time in milliseconds that the negotiation is valid for.
Once the negotiation age exceeds this value, clients should discard it.
required:
- offer
- description
- lifetime
type:
type: string
Expand Down

0 comments on commit 242b62e

Please sign in to comment.