Remove distinction between StateFilter and RoomEventFilter
#2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are exactly the same type, so let's combine their tables together.
richvdh
force-pushed
the
rav/no_state_filter
branch
from
4c26aea to
fa95473
Compare
3 tasks
KitsuneRal
approved these changes
Nov 27, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are exactly the same type, so let's combine their tables together.
History: the distinction was initally added in matrix-org/matrix-spec-proposals#1758, when
lazy_load_memberswasn't supported onRoomEventFilter.lazy_load_memberswas later moved toRoomEventFilterin matrix-org/matrix-spec-proposals#2035, but the distinct name for the object persisted.Preview: https://pr2015--matrix-spec-previews.netlify.app