Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Client Config to Account Data #2032

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −5
Open

Rename Client Config to Account Data #2032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63a4acd
Update _index.md
yoyodragon Dec 14, 2024
f10840c
changing Client Config to Account Data
yoyodragon Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelogs/legacy/client_server.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ Since the draft stage, the following major changes have been made:
- Invites based on third-party identifiers
- Room tagging
- Guest access
- Client config
- Account Data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not edit an old changelog entry.

- The following APIs were added:
- ``/sync``
- ``/publicRooms``
Expand Down
2 changes: 1 addition & 1 deletion content/client-server-api/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2927,7 +2927,7 @@ that profile.
| [Typing Notifications](#typing-notifications) | Required | Required | Required | Required | Optional |
| [User and Room Mentions](#user-and-room-mentions) | Required | Required | Required | Optional | Optional |
| [Voice over IP](#voice-over-ip) | Required | Required | Required | Optional | Optional |
| [Client Config](#client-config) | Optional | Optional | Optional | Optional | Optional |
| [Account Data](#client-config) | Optional | Optional | Optional | Optional | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to apply changes to the URL fragment. #client-config should have been changed to #account-data, here and maybe in other parts of the spec.

| [Device Management](#device-management) | Optional | Optional | Optional | Optional | Optional |
| [End-to-End Encryption](#end-to-end-encryption) | Optional | Optional | Optional | Optional | Optional |
| [Event Annotations and reactions](#event-annotations-and-reactions) | Optional | Optional | Optional | Optional | Optional |
Expand Down
2 changes: 1 addition & 1 deletion content/client-server-api/modules/account_data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

### Client Config
### Account Data

Clients can store custom config data for their account on their
homeserver. This account data will be synced between different devices
Expand Down
2 changes: 1 addition & 1 deletion data/api/client-server/account-data.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.
openapi: 3.1.0
info:
title: Matrix Client-Server Client Config API
title: Matrix Client-Server Account Data API
version: 1.0.0
paths:
"/user/{userId}/account_data/{type}":
Expand Down
2 changes: 1 addition & 1 deletion data/api/client-server/keys.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# limitations under the License.
openapi: 3.1.0
info:
title: Matrix Client-Server Client Config API
title: Matrix Client-Server Account Data API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is quite right (but it was already wrong before). Looking at the spec it looks like it should be "Key Management API" for this file.

version: 1.0.0
paths:
/keys/upload:
Expand Down
Loading