-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing #2301
base: main
Are you sure you want to change the base?
Testing #2301
Conversation
Deploying matrix-website with
|
Latest commit: |
3742e08
|
Status: | ✅ Deploy successful! |
Preview URL: | https://804f32a3.matrix-website.pages.dev |
Branch Preview URL: | https://mtrnord-playwright.matrix-website.pages.dev |
One thing to clear up is if we follow wcag2a or wcag2aa 🤔 (it can be configured) My opinion is to go with aa since we want a partial redesign anyway. But if not its easy to change the tests to only run against a which should allow us to run all tests afaik without skipping. |
One recurring issue is the contrast of the urls we link to by the way. |
6bc6dc7
to
8b739d2
Compare
Since we also just had the case that the frontpage failed due to the link in the new banner (which is also fixed by #2319 ) here is an example where we can find the html reports of these errors: https://github.com/matrix-org/matrix.org/actions/runs/8859887109?pr=2301 under artifacts there is a |
Ensure we run sharded tests on CI Ensure zola is installed Ensure zola is is in path Use blob reporter in CI Use correct commands when merging the reports from playwright
…l for the pagination
… have a h1 header on the client details
b0a4a40
to
0baa5a4
Compare
dc80b2f
to
602f852
Compare
6f0eb05
to
3742e08
Compare
Some more recent issues (#2278 , #2276 , #2261 and #2180 and probably others) have shown a pattern of things that may be possible to catch with testing. So I decided to get a stab at building a simple playwright based testsuite for this.
The testsuite will also bring tests for accessibility based on https://playwright.dev/docs/accessibility-testing which hopefully helps us on that front as well.
Skipped ones are due to issues beyond the scope of the PR.
For example these kinds of accessibility errors:

TODO: