This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove groups/communities from Synapse #12499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/deprecate-groups-3
branch
3 times, most recently
from
28d137e to
5147572
Compare
clokep
force-pushed
the
clokep/deprecate-groups-3
branch
from
5147572 to
8788f96
Compare
clokep
commented
Apr 26, 2022
Comment on lines
+673
to
674
| # Note that the groups key is no longer used and may have bogus values. | ||
| groups_key: int |
There was a problem hiding this comment.
I'm unsure if there is something better to do here? I did debate setting the default for groups_key to 0 so that we don't need to provide it when creating a StreamToken?
(In general, probably look closely over the changes to StreamToken...)
This was referenced Apr 26, 2022
|
This has been mostly split into other PRs (see backlinks or #11584). I'm going to close this. |
This was referenced May 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of commits that removes the groups/communities code from Synapse.
I worked from the outside in, mostly, starting with the servlets & handlers, then the outgoing federation code, then the datastore code, then any other misc utilities.
It should generally be reviewable commit-by-commit, but the overall PR is rather massive. I can split this out into more logical pieces if people would prefer.
This needs to land in Synapse v1.59.0 or later.
A future PR will bump the database schema and remove the various groups tables.
Part of #11584.