This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Refactor the configure_workers_and_start.py
script used internally by Complement.
#16650
Open
reivilibre
wants to merge
18
commits into
develop
Choose a base branch
from
rei/cwas_extension
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reivilibre
force-pushed
the
rei/cwas_extension
branch
from
November 17, 2023 11:17
672e655
to
c6b04cd
Compare
…the extra config template
…arate function for that
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
reivilibre
force-pushed
the
rei/cwas_extension
branch
from
November 17, 2023 12:04
c6b04cd
to
576cade
Compare
clokep
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it seems like good changes, but I have a couple of questions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base:
develop
This pull request is intended for commit-by-commit review.
Original commit schedule, with full messages:
Remove obsolete
"app"
from worker templatesConvert worker templates into dataclass
Use a lambda for the worker name rather than search and replace later
Collapse WORKERS_CONFIG by removing entries with defaults
Convert listener_resources and endpoint_patterns to Set[str]
Tweak comments
Add
merge_into
Remove special logic for adding stream_writers: just make it part of the extra config template
Rename function to add_worker_to_instance_map given reduction of scope
Add
sharding_allowed
to the WorkerTemplate rather than having a separate function for thatUse
merge_into
when adding workers to the shared configPromote mark_filepath to constant
Add a --generate-only option