Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Synapse Admin API quarantine path #1380

Merged
merged 2 commits into from
May 15, 2024
Merged

Update Synapse Admin API quarantine path #1380

merged 2 commits into from
May 15, 2024

Conversation

anoadragon453
Copy link
Member

This path was deprecated nearly 4 years ago in matrix-org/synapse#6681.

This path was deprecated nearly 4 years ago in matrix-org/synapse#6681.

The old path is consistently causing CI failures on `develop`.
@anoadragon453 anoadragon453 requested a review from a team as a code owner May 14, 2024 14:36
@anoadragon453
Copy link
Member Author

anoadragon453 commented May 14, 2024

That test failure exists on develop as well, and isn't related to this PR. We should try to fix it separately, however we shouldn't merge this until that test passes, so that we can check this change works.

@anoadragon453
Copy link
Member Author

The problem is that the Admin API request is going to the main process, whereas it should be going to the media worker. As we disable media functionality, including media-related Admin API functionality, in Sytest's Synapse when workers are enabled:

enable_media_repo => ( not $self->{workers} ),

https://github.com/element-hq/synapse/blob/1e68b56a623a0d7f98106482bfed223c22193050/synapse/rest/admin/__init__.py#L351-L352

@anoadragon453
Copy link
Member Author

The problem is that the Admin API request is going to the main process, whereas it should be going to the media worker.

Should be fixed by #1381.

@anoadragon453 anoadragon453 merged commit 9401037 into develop May 15, 2024
9 checks passed
@anoadragon453 anoadragon453 deleted the anoa/fix_ci branch May 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants