[feat] mutex + fiber + thread + io || DRAFT

[ms-jpq]

This is just a draft, havn't wrote the tests and ensured everything works 100% yet, and I also need to add in a bunch of doc comments.

Please do leave comments & stuff for things you want to changed / updated tho <3.

Would really appreciate any points on better approaches to do things.

[matsadler]

Thanks so much for this!

I have basically no free time at the moment (who'd have thought having a 1 month old baby and my parents visiting from overseas would take up so much time?) so it might take a while to get back to you on this.

Normally I'd try to get all my feedback submitted at once, but that might take a very long time before you get any feedback at all, so my plan is to review individual parts as and when I can. If this turns out to be annoying, just let me know and I'll hold off on individual comments until I can do everything at once.

[ms-jpq]

hey dw about it, i will just add in all the comments and tests and what not, and set it to ready for review.
for when ever you are ready.

btw enjoy your baby! :D :D :D must be exciting <3

[ianks]

@ms-jpq Thanks for your work here!

It would be helpful to split this PR into multiple PRs — one for IO, Fiber, etc. Would make it easier to review.

[matsadler]

Can this call try_convert()? Like:

pub fn resume<A, T>(&self, args: A) -> Result<T, Error>
where
    A: ArgList,
    T: TryConvert,
{
    ...
    .and_then(|v| v.try_convert())
}

[ms-jpq]

done. and added it for all the other methods.

One thing I also added in relation to this is impl TryConvert for (), because of ergonomics.

Right now this checks for is_nil, but not sure if thats necessary or not, you call.

[ms-jpq]

@ms-jpq Thanks for your work here!

It would be helpful to split this PR into multiple PRs — one for IO, Fiber, etc. Would make it easier to review.

yeah, I will try.

Im actually using this repo for work project right now, so its a bit hard for me to do that and keep everything in sync in a timely manner since Im reassigned temporarily.

Edit, ok yeah

I just added a whole bunch more surface area. This PR needs to be split up.

[ms-jpq]

Seems like some APIs that should be available on windows were missing, and failing the CI.

oxidize-rb/rb-sys#66

Edit resolved.