Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1546

Closed
wants to merge 1 commit into from
Closed

Update README.md #1546

wants to merge 1 commit into from

Conversation

libern
Copy link

@libern libern commented Nov 22, 2019

As a guide for people afterwards, I am facing this issue: icanzilb/EasyAnimation#14

  • Project Name:
  • Project URL:
  • Project Description:
  • Why it should be added to awesome-swift:
  • At least 15 stars (GitHub project)
  • Support Swift 5
  • Updated contents.json instead of README
  • Lib is fully open sourced, written in Swift and not a wrapper over compiled lib
  • Description does not say "written in Swift" or variant 🤓

As a guide for people afterwards, I am facing this issue: icanzilb/EasyAnimation#14
@@ -303,7 +303,7 @@ PLEASE DO NOT UPDATE THIS FILE, UPDATE CONTENTS.JSON INSTEAD. THANK YOU :-)
* [Comets](https://github.com/cruisediary/Comets) - Animating Particles.
* [DKChainableAnimationKit](https://github.com/Draveness/DKChainableAnimationKit) - Easy to read and write chainable animations.
* [Ease](https://github.com/roberthein/Ease) - Animate everything with Ease.
* [EasyAnimation](https://github.com/icanzilb/EasyAnimation) - A library to take the power of UIView.animateWithDuration(_:, animations:...) to a whole new level.
* [EasyAnimation](https://github.com/icanzilb/EasyAnimation) - (Not Maintained & Issues: Breaks popover presentation animation) A library to take the power of UIView.animateWithDuration(_:, animations:...) to a whole new level.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephencelis Please update contents.json instead of Readme.md

@vpeschenkov
Copy link
Collaborator

I'm not sure that it is a good idea to blame somebody here like this. Let's just remove this from the list? I think that one year of inactivity is enough to say that the library is not actively maintained and remove it.

@matteocrippa, @dkhamsing, @serhii-londar What do you guys think?

@matteocrippa
Copy link
Owner

@vpeschenkov I do agree, if the lib is not maintained as written in the guideline @libern can make a PR in the proper way and suggest to remove to that lib if really have issue providing evidence of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants