Replacing Request with node-fetch #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matteodanelli Are you still maintaining this module? This PR is probably obsolete, since you switched to https. |
|
Hi! Yes, I'm not currently using anymore but I maintain it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request was removed from Magic mirror since Request has been depreciated. node-fetch is a replacement to do the GET request and pass the json back to the results. Also added a package.json with the node-fetch dependency to make sure the clients pull it down and have it. new Steps included in the read-me. (PS: first public PR to a project, feed back is appreciated 👍 )