feat: shared bridge support #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit f836401): https://staging-zksync-dapp-wallet-v2--pr178-feat-20240523-v24-165chxrq.web.app (expires Wed, 10 Jul 2024 15:09:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a25831e6058958ccabf0f806505b5b8e7241b178 |
JackHamer09
requested changes
Jun 5, 2024
JackHamer09
approved these changes
Jul 3, 2024
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Withdrawls from L2 to L1 with a custom native gas token, now no longer work. They still work if I use the code from the feature branch that was merged in this PR. Fee estimation fails with the error - UNPREDICTABLE_GAS_LIMIT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added v24 support: using the shared bridge instead of era's legacy erc-20 bridge.
Why
Until now the portal used era's backward compatibility. For other ZK chains to be able to use it, shared bridge compatibility is needed.