fix: disable token select while fee is loading to prevent fee overrides #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Romsters
changed the title
|
Visit the preview URL for this PR (updated for commit 6f5de0e): https://staging-zksync-dapp-wallet-v2--pr191-fix-deposit-fee-i7akyjf0.web.app (expires Fri, 06 Sep 2024 13:10:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a25831e6058958ccabf0f806505b5b8e7241b178 |
vasyl-ivanchuk
approved these changes
Aug 30, 2024
|
🎉 This PR is included in version 1.25.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Initially fee is requested for the default token, if another token is selected another fee request is triggered, if the first one takes longer than the second one it overrides the fee with incorrect data for the previous token selected. This happens quite often if default token is ETH as it takes more time to estimate deposit fee for ETH than for ERC20 for example.