Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add separate index for zk_ee #11

Merged
merged 3 commits into from
Jan 13, 2025
Merged

feat: Add separate index for zk_ee #11

merged 3 commits into from
Jan 13, 2025

Conversation

0xVolosnikov
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

antoniolocascio
antoniolocascio reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@antoniolocascio antoniolocascio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the zk-ee index a copy of the emulator's? If so, do we want to disable all the tests that were disabled there?

@0xVolosnikov 0xVolosnikov merged commit d24ec18 into zk-ee Jan 13, 2025
1 check passed
@0xVolosnikov 0xVolosnikov deleted the vv-add-separate-index-for-zk-ee branch January 13, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniolocascio antoniolocascio antoniolocascio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xVolosnikov @antoniolocascio