Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support newer versions of foundry-zksync #3556

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix: Support newer versions of foundry-zksync #3556

merged 1 commit into from
Feb 7, 2025

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Jan 30, 2025

zksync_contracts is some spilled spaghetti.

@popzxc popzxc marked this pull request as draft January 30, 2025 14:17
@popzxc popzxc force-pushed the popzxc-fix-foundry branch from 2524f0d to 3fa3810 Compare February 3, 2025 11:16
@popzxc popzxc marked this pull request as ready for review February 3, 2025 14:47
slowli
slowli reviewed Feb 6, 2025
View reviewed changes
core/lib/contracts/src/lib.rs Outdated Show resolved Hide resolved
core/lib/contracts/src/lib.rs Outdated Show resolved Hide resolved
core/lib/contract_verifier/src/contract_identifier.rs Outdated Show resolved Hide resolved
@itegulov
Copy link
Contributor

itegulov commented Feb 6, 2025 •
edited
Loading

Could you also update github workflows to download fresh version of foundry?

FWIW this PR works for me locally but would be good to know that CI agrees

UPD: Nevermind, comment explains why this is not possible right now

Deniallugo
Deniallugo previously approved these changes Feb 6, 2025
View reviewed changes
@popzxc popzxc force-pushed the popzxc-fix-foundry branch from 3fa3810 to 86aa46e Compare February 7, 2025 07:03
@popzxc popzxc enabled auto-merge February 7, 2025 08:15
@popzxc popzxc added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@Deniallugo Deniallugo added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit d39fb6d Feb 7, 2025
33 checks passed
@Deniallugo Deniallugo deleted the popzxc-fix-foundry branch February 7, 2025 10:09
@zksync-era-bot zksync-era-bot mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowli slowli slowli left review comments

@itegulov itegulov itegulov approved these changes

@Deniallugo Deniallugo Deniallugo left review comments

@perekopskiy perekopskiy Awaiting requested review from perekopskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@popzxc @itegulov @Deniallugo @slowli