Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-18 - Improve hashtag help text #19

Merged
merged 3 commits into from
Mar 22, 2020
Merged

GH-18 - Improve hashtag help text #19

merged 3 commits into from
Mar 22, 2020

Conversation

marianunez
Copy link
Contributor

@marianunez marianunez commented Mar 18, 2020

Summary

Specified reference date that must be included in the date format for the meeting hashtag. Follow up from PR #2

Screenshot

Screen Shot 2020-03-16 at 9 25 46 AM

Ticket Link

Fixes #18

@marianunez marianunez added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 18, 2020
@marianunez
Copy link
Contributor Author

Specific wording is open for suggestions

@hanzei hanzei added this to the v0.1 milestone Mar 18, 2020
@hanzei hanzei linked an issue Mar 18, 2020 that may be closed by this pull request
Copy link
Contributor

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion below, but non-blocking.

Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marianunez.

+1 for the text change suggestion from Jesse.

@marianunez
Copy link
Contributor Author

Updated to:

Screen Shot 2020-03-19 at 9 52 39 AM

@marianunez marianunez removed the 2: Dev Review Requires review by a core committer label Mar 19, 2020
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed update to help text.
LGTM!
Thank you @marianunez This will make the current UI design far easier to use.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Mar 22, 2020
@marianunez marianunez merged commit 9892a00 into pluginReview Mar 22, 2020
@marianunez marianunez deleted the GH-18 branch March 22, 2020 20:39
marianunez added a commit that referenced this pull request Mar 24, 2020
* Improved date format help text

* Updated help text

* Linting
@marianunez
Copy link
Contributor Author

@lieut-data I mistakenly merged this PR to the review branch and the change is not present in the current version on community. 🤦‍♀️

I cherry-picked it and it's now available in master whenever a new version can be cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve help text in Agenda modal
5 participants