Plugin review proposals #3
Conversation
|
Hi @marianunez and @levb. This is a PR that can be used to let the authors and devs see the proposed changes I would make. Note this is currently a draft PR and I will be making for commits. |
err var renamed to appErr when model.AppError is return type
|
1/5 for merging incrementally |
@levb Can you explain what you mean by incrementally? |
|
@marianunez Like, in merge the changes we already have here (once approved), and cut another PR if we need to make more changes. |
|
@levb, for this plugin, I have created this PR so that @marianunez can review the changes before merging. This is a little different than the google calendar plugin, where I basically took ownership and merged changes directly. @marianunez, if these changes look good for your approval, let's go ahead and approve/merge and I'll create additional PRs for other changes. |
jfrerich
added
4: Reviews Complete
* Full commit without template for review * Linting * Plugin review proposals (#3) * spelling * spelling * fix make golint errors * Break up sentence into multiple * Spelling fixes in webapp and server err var renamed to appErr when model.AppError is return type * remove broken to ticket. The fix is now in mm-webapp master * go mod tidy * Updated Readme. Dropped plugin in plugin id * Added Sat-Sun. Dropped plugin in name * Weekdays fixes * PR Feedback * Fixing Makefile * Fixing merge conflicts * Added help command * Updated UI * linting * More linting. Sorry for the churn here * Update go module name * checkin results from npm-check -E -y * remove references to starter template remove public/hellow.html * fix lint error * Add Contributing section to README Co-authored-by: Jason Frerich <[email protected]>
Summary
This is a PR with suggested changes discovered during the Plugin Review Process. The purpose of this 2nd PR is to give both the plugin author and other developers the chance to review changes before pushing into master.