Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agenda item number should get updated if the items of the agenda are deleted #79

Closed

Conversation

maisnamrajusingh
Copy link
Contributor

Summary

Agenda item number should get updated if the items of the agenda are deleted

Ticket Link

#47

sanjaydemansol and others added 5 commits June 28, 2021 19:10
Agenda item number should get updated if the items of the agenda are deleted
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #79 (9b332a8) into master (2f22484) will decrease coverage by 3.73%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   26.03%   22.29%   -3.74%     
==========================================
  Files           7        7              
  Lines         315      453     +138     
==========================================
+ Hits           82      101      +19     
- Misses        216      334     +118     
- Partials       17       18       +1     
Impacted Files Coverage Δ
server/command.go 0.00% <0.00%> (ø)
server/utils.go 72.54% <0.00%> (-21.40%) ⬇️
server/meeting.go 62.06% <50.00%> (-0.98%) ⬇️
server/main.go 0.00% <0.00%> (ø)
server/manifest.go 100.00% <0.00%> (ø)
server/configuration.go 0.00% <0.00%> (ø)
server/plugin.go 25.74% <0.00%> (+3.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f22484...9b332a8. Read the comment docs.

@hanzei
Copy link
Contributor

hanzei commented Jul 12, 2021

@maisnamrajusingh There seem to be a lot of unrelated changes in this PR. Could you please double check that only needed changes got in here?

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jul 12, 2021
@maisnamraju
Copy link

@maisnamrajusingh There seem to be a lot of unrelated changes in this PR. Could you please double check that only needed changes got in here?

yup, seems there are unrelated changes. Sorry about that, will update later today or tomorrow.

@maisnamrajusingh maisnamrajusingh deleted the mm-47 branch July 13, 2021 09:38
@maisnamrajusingh maisnamrajusingh restored the mm-47 branch July 13, 2021 09:38
@maisnamrajusingh maisnamrajusingh deleted the mm-47 branch July 13, 2021 09:38
@maisnamrajusingh maisnamrajusingh restored the mm-47 branch July 13, 2021 09:39
@hanzei hanzei added Invalid This doesn't seem right and removed 2: Dev Review Requires review by a core committer labels Jul 13, 2021
@maisnamrajusingh maisnamrajusingh deleted the mm-47 branch July 14, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants