Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case where you assign yourself your own todo #203

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

mickmister
Copy link
Contributor

Summary

Users reported an issue where if you assign yourself to todo that is in your owned todos, the todo would end up in a weird state where you can't access it in either list. This is because it would delete the todo from your list, making it so it's not part of any list.

This PR makes it so it doesn't delete it from your list when you do this.

Ticket Link

Fixes #200

@mickmister mickmister requested a review from asaadmahmood March 27, 2023 21:36
@mickmister mickmister requested a review from larkox as a code owner March 27, 2023 21:36
@mickmister mickmister added the 3: QA Review Requires review by a QA tester label Mar 28, 2023
@mickmister mickmister requested a review from DHaussermann March 28, 2023 18:11
@hanzei hanzei modified the milestones: v0.7.0, v0.8.0 Mar 28, 2023
@hanzei hanzei removed the request for review from DHaussermann October 16, 2023 20:38
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR for the following scenario:-

  • Created a ToDo.
  • Assigned the Todo to myself

The PR was working fine as the ToDo was getting reflected in the My ToDo list, LGTM. Approved.

@AayushChaudhary0001
Copy link

@ayusht2810 Please check this once as some checks are failing for this PR.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 6.87%. Comparing base (968b119) to head (156c025).
Report is 1 commits behind head on master.

❗ Current head 156c025 differs from pull request most recent head 1a2ceb8. Consider uploading reports for the commit 1a2ceb8 to get more accurate results

Files Patch % Lines
server/list.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #203      +/-   ##
=========================================
+ Coverage    6.32%   6.87%   +0.54%     
=========================================
  Files          10      10              
  Lines        1708    1601     -107     
=========================================
+ Hits          108     110       +2     
+ Misses       1592    1483     -109     
  Partials        8       8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister
Copy link
Contributor Author

@AayushChaudhary0001 CI is fixed now

@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Apr 16, 2024
@mickmister mickmister merged commit d7932b3 into master Apr 16, 2024
4 checks passed
@mickmister mickmister deleted the fix-self-assign-issue branch April 16, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Todo can get stuck if not careful
7 participants