-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix case where you assign yourself your own todo #203
Conversation
… into fix-self-assign-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this PR for the following scenario:-
- Created a ToDo.
- Assigned the Todo to myself
The PR was working fine as the ToDo was getting reflected in the My ToDo list, LGTM. Approved.
@ayusht2810 Please check this once as some checks are failing for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
=========================================
+ Coverage 6.32% 6.87% +0.54%
=========================================
Files 10 10
Lines 1708 1601 -107
=========================================
+ Hits 108 110 +2
+ Misses 1592 1483 -109
Partials 8 8 ☔ View full report in Codecov by Sentry. |
@AayushChaudhary0001 CI is fixed now |
Summary
Users reported an issue where if you assign yourself to todo that is in your owned todos, the todo would end up in a weird state where you can't access it in either list. This is because it would delete the todo from your list, making it so it's not part of any list.
This PR makes it so it doesn't delete it from your list when you do this.
Ticket Link
Fixes #200