Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Mattermost Plugins E2E Utils as a dependency #258

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

panoramix360
Copy link

@panoramix360 panoramix360 commented May 31, 2024

This PR is intended to test the integration with the Mattermost Plugins E2E Utils that I'm working on with @mickmister!

I'm creating as a draft for now, so we can test it.

Related PR in mattermost-plugin-e2e-test-utils repo
mattermost-community/mattermost-plugin-e2e-test-utils#3

Related thread
https://community.mattermost.com/core/pl/w4oistz7rtn4bj9ewfu8neimdh

Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @panoramix360!! This is awesome that we're now connecting the dots between this repo and mattermost-community/mattermost-plugin-e2e-test-utils#3. This is going to be so awesome using this here! 🚀

Next steps here are to adapt the code in e2e/playwright folder that is related to the obsolete configuration:

Please let me know of any questions you may have, and if you feel a video call would be most efficient to discuss this. Thanks so much @panoramix360! Great job!!

e2e/playwright/package.json Outdated Show resolved Hide resolved
@mickmister
Copy link
Contributor

From my comment above:

Any functionality imported from @e2e-support/* should be relocated to the shared package.

I'm thinking a lot of this stuff is already in the shared package. If there's anything else that this @e2e-support import is providing, we can move it over to the shared package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants