Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-262 - fix issue gui unresponsive when adding a todo #265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GH-262 - fix issue gui unresponsive when adding a todo #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions webapp/src/components/add_issue/add_issue.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,14 @@ export default class AddIssue extends React.PureComponent {
attachToThread: false,
previewMarkdown: false,
assigneeModal: false,
isTyping: false,
};
}

static getDerivedStateFromProps(props, state) {
if (state.isTyping) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every type stroke rerenders the component and causes messages to get the props value. This change tracks when the user is typing and will avoid this situation from happening.

return null;
}
if (props.visible && (props.message !== state.message || props.postPermalink !== state.postPermalink)) {
return {
message: props.message,
Expand Down Expand Up @@ -88,6 +92,7 @@ export default class AddIssue extends React.PureComponent {
message: '',
description: '',
postPermalink: '',
isTyping: false,
});

if (attachToThread) {
Expand Down Expand Up @@ -123,6 +128,7 @@ export default class AddIssue extends React.PureComponent {
handleInputChange = (e, field) => {
this.setState({
[field]: e.target.value,
isTyping: true,
});
}

Expand Down
Loading