Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deinitialize with uninitialize #1424

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

hmhealey
Copy link
Member

@hmhealey hmhealey commented Dec 5, 2024

Summary

Very early on, web app plugins had a method called deinitialize which gets run when they're disabled, but that got replaced by an uninitialize method using a more standard name. This doesn't actually name the method, but it's probably good to not potentially lead people to using the method.

Related Pull Requests

mattermost/mattermost#29386

@hmhealey hmhealey added the 2: Editor Review Requires review by an editor label Dec 5, 2024
@hmhealey hmhealey requested a review from cwarnermm December 5, 2024 18:37
Copy link

github-actions bot commented Dec 5, 2024

Newest code from mattermost has been published to preview environment for Git SHA fecf9cf

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hmhealey!!

@cwarnermm cwarnermm requested a review from amyblais December 5, 2024 18:39
@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor labels Dec 5, 2024
@cwarnermm cwarnermm merged commit d8879ef into master Dec 6, 2024
6 checks passed
@cwarnermm cwarnermm deleted the hmhealey-patch-1 branch December 6, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants