Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get aws client with region set up in config #856

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

fmartingr
Copy link
Contributor

Summary

We have the AWS Region parameter but that can conflict with the default values or the profile values (specifically if region is not set there).

This pull request adds the region option when creating the AWS Client to match the one in the configuration.

Ticket Link

https://mattermost.atlassian.net/browse/MM-61279

@fmartingr fmartingr added the 2: Dev Review Requires review by a core committer label Nov 25, 2024
@fmartingr fmartingr self-assigned this Nov 25, 2024
Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this behave when no region nor profile is set? We need to use the default credential chain in the automated load-tests, so it's important that we keep that same behaviour.

@fmartingr
Copy link
Contributor Author

How does this behave when no region nor profile is set? We need to use the default credential chain in the automated load-tests, so it's important that we keep that same behaviour.

I have not tested this scenario, thought that the region field was mandatory (since it has a default value) but it can be emptied. Have we emptied the field explicitly in the CI configuration files? How does the automated load test get the credentials?

@agarciamontoro
Copy link
Member

Oh, I checked and I have that set up in the automated load-test config templates as well. Could you run a quick test to verify all is good with that set of files? https://github.com/mattermost/mattermost-load-test-ng/tree/master/examples/config/ci

@fmartingr
Copy link
Contributor Author

Oh, I checked and I have that set up in the automated load-test config templates as well. Could you run a quick test to verify all is good with that set of files? https://github.com/mattermost/mattermost-load-test-ng/tree/master/examples/config/ci

Just created a deployment from this branch used those settings. The envionment was created without errors.

@fmartingr fmartingr requested a review from streamer45 December 11, 2024 12:54
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense 👍

Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fmartingr, looks great :)

@fmartingr fmartingr removed the 2: Dev Review Requires review by a core committer label Dec 12, 2024
@fmartingr fmartingr merged commit 7f6b71e into master Dec 12, 2024
1 check passed
@fmartingr fmartingr deleted the chore/use-aws-region-in-config branch December 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants